-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(ci): consolidate ci, make db migrations dependent on ecr success, remove turbopack for staging/prod builds #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
This PR partially removes turbopack by removing the --turbopack flag from the build script, reverting to webpack for production builds. However, the removal is incomplete as the dev script still uses the --turbo flag.
- Removes
--turbopackfrom build script, switching production builds back to webpack - Creates inconsistency: development still uses turbopack while production uses webpack
- May impact build performance and behavior differences between environments
Confidence Score: 2/5
- This PR has inconsistent turbopack removal that could cause dev/prod environment differences
- Score reflects incomplete implementation with potential environment inconsistencies between development and production builds
- apps/sim/package.json requires attention to complete turbopack removal consistently
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| apps/sim/package.json | 2/5 | Inconsistent turbopack removal - build script updated but dev script still has --turbo flag |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant CI as CI/CD Pipeline
participant Next as Next.js
participant Turbo as Turbopack
Note over Dev, Turbo: Before: Build Process with Turbopack
Dev->>CI: Triggers build process
CI->>Next: Runs "next build --turbopack"
Next->>Turbo: Uses turbopack bundler
Turbo->>Next: Returns optimized build
Next->>CI: Build complete with turbopack
Note over Dev, Turbo: After: Build Process without Turbopack
Dev->>CI: Triggers build process
CI->>Next: Runs "next build" (default webpack)
Next->>Next: Uses default webpack bundler
Next->>CI: Build complete with webpack
Note over Dev: Issue: Dev script still uses --turbo flag
Dev->>Next: Runs "next dev --turbo --port 3000"
Next->>Turbo: Still uses turbopack in development
1 file reviewed, 1 comment
| on: | ||
| push: | ||
| branches: [main, staging] | ||
| workflow_call: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes it reusable (can be called from ci)
| resolveExtensions: ['.tsx', '.ts', '.jsx', '.js', '.mjs', '.json'], | ||
| }, | ||
| serverExternalPackages: ['pdf-parse'], | ||
| serverExternalPackages: ['pdf-parse', '@azure/storage-blob'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this actually needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea
Summary
Removes turbopack for dh builds
Fixes #(issue)
Type of Change
Testing
Local
Checklist