Skip to content

Conversation

@Sg312
Copy link
Contributor

@Sg312 Sg312 commented Sep 25, 2025

Summary

Removes turbopack for dh builds

Fixes #(issue)

Type of Change

  • Bug fix

Testing

Local

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sim Ready Ready Preview Comment Sep 25, 2025 7:12pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Sep 25, 2025 7:12pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR partially removes turbopack by removing the --turbopack flag from the build script, reverting to webpack for production builds. However, the removal is incomplete as the dev script still uses the --turbo flag.

  • Removes --turbopack from build script, switching production builds back to webpack
  • Creates inconsistency: development still uses turbopack while production uses webpack
  • May impact build performance and behavior differences between environments

Confidence Score: 2/5

  • This PR has inconsistent turbopack removal that could cause dev/prod environment differences
  • Score reflects incomplete implementation with potential environment inconsistencies between development and production builds
  • apps/sim/package.json requires attention to complete turbopack removal consistently

Important Files Changed

File Analysis

Filename        Score        Overview
apps/sim/package.json 2/5 Inconsistent turbopack removal - build script updated but dev script still has --turbo flag

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CI as CI/CD Pipeline
    participant Next as Next.js
    participant Turbo as Turbopack

    Note over Dev, Turbo: Before: Build Process with Turbopack
    Dev->>CI: Triggers build process
    CI->>Next: Runs "next build --turbopack"
    Next->>Turbo: Uses turbopack bundler
    Turbo->>Next: Returns optimized build
    Next->>CI: Build complete with turbopack

    Note over Dev, Turbo: After: Build Process without Turbopack
    Dev->>CI: Triggers build process
    CI->>Next: Runs "next build" (default webpack)
    Next->>Next: Uses default webpack bundler
    Next->>CI: Build complete with webpack

    Note over Dev: Issue: Dev script still uses --turbo flag
    Dev->>Next: Runs "next dev --turbo --port 3000"
    Next->>Turbo: Still uses turbopack in development
Loading

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@vercel vercel bot temporarily deployed to Preview – docs September 25, 2025 17:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs September 25, 2025 17:38 Inactive
@Sg312 Sg312 changed the title Remove turbopack feat(build): remove turbopack for staging/prod builds Sep 25, 2025
@Sg312 Sg312 changed the title feat(build): remove turbopack for staging/prod builds feat(ci): consolidate ci, make db migrations dependent on ecr success, remove turbopack for staging/prod builds Sep 25, 2025
@vercel vercel bot temporarily deployed to Preview – docs September 25, 2025 19:04 Inactive
on:
push:
branches: [main, staging]
workflow_call:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes it reusable (can be called from ci)

resolveExtensions: ['.tsx', '.ts', '.jsx', '.js', '.mjs', '.json'],
},
serverExternalPackages: ['pdf-parse'],
serverExternalPackages: ['pdf-parse', '@azure/storage-blob'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this actually needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea

@Sg312 Sg312 merged commit d381a69 into staging Sep 25, 2025
11 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/remove-turbopack branch October 13, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants